Closed Soham1803 closed 6 months ago
Hello @Soham1803, Thank you for your PR, I made several change requests before accepting to merge it,
let me know if you need more informations
Hey @ManyTheFish I have made the requested changes can you please check and let me know. Thank You!
Hello @Soham1803,
The tests don't seem to work. Could you fix them?
Thank you
Build failed:
Hey @ManyTheFish, I'm trying to run the tests on my local machine but got some issues with jemalloc-sys
in .cargo. The last commit I made is based on the logs of test run I read on Github. Its good if the tests pass now, or else I will make another commit after being assured all the tests are passed.
Hey @ManyTheFish sorry for the delay. Thanks for your suggested changes. The last commit passed all the tests on local successfully, after many different tryouts. Made some major changes to the Normalizer. Suggest me any changes if necessary before the merge.
Thank You!
Hello @Soham1803
@ManyTheFish is on Holidays and will review your PR when coming back
In the meantime, can you fix the Rustfmt tests? 😊
Thanks again for your PR
Hello @curquiza, dealt with the Rustfmt tests. I guess all tests are passed. Now, just waiting for @ManyTheFish to suggest any required changes before the merge.
Thank You! 😊
Build succeeded:
Nice to have you back @ManyTheFish. Thanks for accepting my PR and the help you provided. 😊
Pull Request
Related issue
Fixes #268
What does this PR do?
œ
andŒ
tooe
,æ
andÆ
toae
.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!