Create image version that works in arm environments

meilisearch / docs-scraper

Scrape documentation into Meilisearch

https://www.meilisearch.com

Other

284 stars 49 forks source link

Create image version that works in arm environments #288

Closed bidoubiwa closed 1 year ago

bidoubiwa commented 1 year ago

Currently, the image from the docker hub only works in an amd environment. Nonetheless, we should be compatible with arm as well.

TODO:

[x] Update publish-docker-latest, following the example of the docker CI of meilisearch. Note that we do not need the corn trigger nor the Send CI information to Cloud team.
[x] Remove publish-docker-tag.yml
[ ] Update the README accordingly, explaining how to run in both env using docker

brunoocasali commented 1 year ago

Why do we need this step?

update the release drafter so that it creates two release drafts, one for amd one for arm.

bidoubiwa commented 1 year ago

You'r right, they could be done in the same release. Let me update the description

brunoocasali commented 1 year ago

Update the README accordingly, explaining how to run in both env using docker

I don't think this could be applied because the change did not impact the way we "run" the code. We just added a new image architecture in the docker hub.