parasyte commented 1 year ago

Pull Request

What does this PR do?

This allows building without pulling in unused dependencies.

The following command should print an error, because the serde-json feature is not enabled:

$ cargo tree --no-default-features --features 'serde-bincode' -i serde_json

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Kerollmops commented 1 year ago

Hey @parasyte 👋

Thank you for this PR. That's much better than the current behavior. If someone wants to enable these features, it only has to specify them here:

Merging this right now 🎸

I will release that just after, but keep in mind that it will be available on the v0.20.0-alpha.2.

Kerollmops commented 1 year ago