Fix clippy warnings - Githubissues

meilisearch / heed

A fully typed LMDB wrapper with minimum overhead 🐦

https://docs.rs/heed

MIT License

569 stars 52 forks source link

Fix clippy warnings #178

Closed AureliaDolo closed 1 year ago

AureliaDolo commented 1 year ago

Hello!

This PR fixes most clippy lints.

For the Safety doc of EnvOpenOptions::flag I retrieved your comment here

The yet to fix lints are :

[x] Safety doc for RwRevIter::append
[x] Safety doc for Env::copy_to_fd
[x] Module inception for iter modules

I'd happily take your input regarding this issues.

Thanks !

AureliaDolo commented 1 year ago

Thanks for the review !

The renaming of the iterator module should not have an impact on users as iterators are re exported.

Ho :open_mouth: I just noticed that the env::EnvInfo struct is not reexported to the lib.rs file, could you fix it here, please? I don't know why the compiler/doc compiler said nothing.

I think it's because you may have wanted to use EnvInfo in other modules, but not expose it to the great outside

Kerollmops commented 1 year ago

Looks perfect to me. Thank you very much! Nice job!