We found out that implementing Sync for RoTxn is unsafe, it should instead only implement Send. This PR changes the sync-read-txn to send-read-txn, and replaces the implementation Sync for RoTxn with Send
PR checklist
Please check if your PR fulfills the following requirements:
[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
Pull Request
Related issue
Fixes #191
What does this PR do?
We found out that implementing
Sync
forRoTxn
is unsafe, it should instead only implementSend
. This PR changes thesync-read-txn
tosend-read-txn
, and replaces the implementationSync
forRoTxn
withSend
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!