meilisearch / heed

A fully typed LMDB wrapper with minimum overhead 🐦

https://docs.rs/heed

MIT License

569 stars 52 forks source link

Add `rmp-serde` support to heed-types. #204

Closed aalekhpatel07 closed 1 year ago

aalekhpatel07 commented 1 year ago

Pull Request

Related issue

None, afaict.

What does this PR do?

Expose a utility struct that represents data that can be serialized and deserialized with rmp-serde.

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

aalekhpatel07 commented 1 year ago

Absolutely!

Clippy didn't seem too happy about a couple of other spots. I think its a tiny change but if it adds too much noise to the diff, lmk and I'll revert it.

aalekhpatel07 commented 1 year ago

Sure I could do that. Or if we don't want to enable all features for all the examples necessarily, we could also run the rmp-serde example separately. Thoughts?

Kerollmops commented 1 year ago

That's, indeed, much better 🙏

aalekhpatel07 commented 1 year ago

Awesome! lmk if you need anything else on my end.

aalekhpatel07 commented 1 year ago

For sure! Hopefully the rebase went fine.

Kerollmops commented 1 year ago

This will be available in v0.20.0-alpha.5 🎉 Thank you for your work!

As I am the only one available on the team and the tests seem to pass, I will merge by hand without approval 🆘