Set `EnvOpenOptions::open()` to `unsafe` - Githubissues

meilisearch / heed

A fully typed LMDB wrapper with minimum overhead 🐦

https://docs.rs/heed

MIT License

632 stars 57 forks source link

Set `EnvOpenOptions::open()` to `unsafe` #246

Closed hinto-janai closed 8 months ago

hinto-janai commented 9 months ago

Closes https://github.com/meilisearch/heed/issues/207.

fn EnvOpenOptions::open() -> unsafe fn EnvOpenOptions::open()
Adds # Safety documentation
Fixes all callers to use unsafe

heed can actually uphold some of the safety invariants, but for now they are documented so at least users are aware of them.

Unrelated change: the new Env::set_flags (https://github.com/meilisearch/heed/pull/245) doesn't necessarily gain safety from &mut self, so it is changed to &self.