meilisearch / heed

A fully typed LMDB wrapper with minimum overhead 🐦

https://docs.rs/heed

MIT License

519 stars 52 forks source link

Improve performance of `ReservedSpace` #260

Closed nolanderc closed 2 months ago

nolanderc commented 2 months ago

Pull Request

Related issue

Addresses (some) concerns raised in a comment: https://github.com/meilisearch/heed/pull/256#pullrequestreview-2030571441.

What does this PR do?

Marks most methods of ReservedSpace as #[inline] allowing them to be inlined across crate boundaries. Especially for the Write-impl where callers may perform small writes, the overhead of not inlining can be significant.
See https://github.com/Kerollmops/heed-perfs-put-reserved/pull/1 for some benchmarks and details.

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[ ] Have you read the contributing guidelines?
- Where can I find these?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!