search

meilisearch / meilisearch-dart

The Meilisearch API client written for Dart
https://meilisearch.com
MIT License
77 stars 26 forks source link

Enable concurrency for the test suite #298

Closed brunoocasali closed 1 year ago

brunoocasali commented 1 year ago

Currently, the test fails when we remove the --concurrency=1 from the test command.

The idea is to make the tests execute in parallel.

https://github.com/meilisearch/meilisearch-dart/blob/main/.github/workflows/tests.yml#L45

ahmednfwela commented 1 year ago

Since dart test has no concept of cross-file testing (unlike c# for example, which can use Fixtures), we have 2 options here:

  1. Refactor all tests to be under a single group
  2. change the shared tearDown function to be test-dependent and only remove indexes/keys used by that specific test instead of a full database cleanup
ahmednfwela commented 1 year ago

I went ahead with option 2 and did a full refactor https://github.com/meilisearch/meilisearch-dart/pull/299