meilisearch / meilisearch-dart

The Meilisearch API client written for Dart
https://meilisearch.com
MIT License
77 stars 26 forks source link

Ensure the error handling are following the best practice #346

Open brunoocasali opened 1 year ago

brunoocasali commented 1 year ago

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository. Also, if you are a maintainer, please add any clarification and instructions about this issue.

Sorry if this is already wholly/partially implemented. Feel free to let me know about the state of this issue in the repo.

Related to https://github.com/meilisearch/integration-guides/issues/267


:warning: For more information, check https://github.com/meilisearch/integration-guides/issues/267

Ensure this SDK follows the following guidelines:

Essentially all the error should extend from MeilisearchException, the consumers should have a way to catch all the errors. Let us know if this is unclear or you have a better idea!

TODO:

ahmednfwela commented 1 year ago

@brunoocasali I suggest making it MeilisearchException instead of MeilisearchError

brunoocasali commented 1 year ago

Done! @ahmednfwela