Closed curquiza closed 11 months ago
@ahmednfwela @brunoocasali be careful before fixing this kind of issue: https://github.com/meilisearch/meilisearch-dart/issues/340 -> the code samples were not implemented, so the full issue was not done 😊
But still a big thank for the PR @ahmednfwela of course 😄
yes my bad, sometimes I create 3/4 prs a day and forget to add the code samples 😅
bors try
@curquiza I suggest also fixing the link at the top to https://github.com/meilisearch/documentation/blob/main/.code-samples.meilisearch.yaml
I made a PR that supersedes this https://github.com/meilisearch/meilisearch-dart/pull/358 @curquiza
@curquiza I suggest also fixing the link at the top to https://github.com/meilisearch/documentation/blob/main/.code-samples.meilisearch.yaml
I changed the description. Before a kind of documentation existed at this link. I removed it. Not all the code samples are present in https://github.com/meilisearch/documentation/blob/main/.code-samples.meilisearch.yaml
I made a PR that supersedes this #358 @curquiza
Thank you! However, can we still merge this current PR? The goal is to provide an up to date documentation to the users as soon as possible @brunoocasali will review the other PR when he will come back from Holiday 😊
Patch and project coverage have no change.
Comparison is base (
d110365
) 82.03% compared to head (750e82d
) 82.03%. Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
yes sure! we can merge this PR now, but is there a place that contains all the code samples ?
Build failed:
yes sure! we can merge this PR now, but is there a place that contains all the code samples ?
Nope most of them are in the file (https://github.com/meilisearch/documentation/blob/main/.code-samples.meilisearch.yaml) but
I created a script that takes into account these exception to check everything is update to date 😊
Build succeeded:
I created scripts to manage code samples (internal only)
All of them were missing, because the related features are implemented.