meilisearch / meilisearch-dart

The Meilisearch API client written for Dart
https://meilisearch.com
MIT License
77 stars 26 forks source link

Update tests related to the next Meilisearch release (v1.6.0) #368

Closed meili-bot closed 7 months ago

meili-bot commented 8 months ago

Related to this issue: https://github.com/meilisearch/integration-guides/issues/294

This PR:

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

This PR is auto-generated for the pre-release week purpose.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7411ffb) 81.85% compared to head (fb8adad) 75.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## ========================================== - Coverage 81.85% 75.83% -6.03% ========================================== Files 57 55 -2 Lines 1345 1320 -25 ========================================== - Hits 1101 1001 -100 - Misses 244 319 +75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

meili-bors[bot] commented 7 months ago

Build failed:

curquiza commented 7 months ago

@ahmednfwela do you know how to fix this linter issue? 😇

ahmednfwela commented 7 months ago

@curquiza it appears JWTException has been removed from somewhere specifically here:

https://github.com/meilisearch/meilisearch-dart/blob/7635e6627a1bd0f65d77084a605440e80598fead/test/tenant_token_test.dart#L85C25-L85C37

ahmednfwela commented 7 months ago

What's weird is that locally there are no errors

brunoocasali commented 7 months ago

My local environment is completely wrecked 🐙

image
brunoocasali commented 7 months ago

I was running with dart 3.2.3, let's see with 3.2.4

ahmednfwela commented 7 months ago

I currently have Dart SDK version: 3.2.3 (stable) (Tue Dec 5 17:58:33 2023 +0000) on "windows_x64"

brunoocasali commented 7 months ago

I didn't get the deps from tools, now I have the same as you @ahmednfwela no error locally...

ahmednfwela commented 7 months ago

Looking at the errors though, it seems it's restoring an older version of dart_jsonwebtoken 2.3.2 (2.12.2 available) https://github.com/meilisearch/meilisearch-dart/actions/runs/7529114617/job/20492688294#step:4:28

but JWTException was introduced at 2.8.0 (I even commented there at the time for the same reason)

seems like we have to update all packages in pubspec.yaml to the latest minor version to fix this

ahmednfwela commented 7 months ago

All green now 👍

curquiza commented 7 months ago

bors merge

meili-bors[bot] commented 7 months ago

Build succeeded: