meilisearch / meilisearch-dotnet

.NET wrapper for the Meilisearch API
https://meilisearch.com
MIT License
273 stars 58 forks source link

[v1.9] Support `rankingScoreThreshold` search parameter #544

Closed curquiza closed 25 minutes ago

curquiza commented 4 months ago

Following this central issue

This is related to a newly introduced feature in Meilisearch v1.9.0: the rankingScoreThreshold search parameter.

Refer to docs for more information.

danFbach commented 2 weeks ago

@curquiza this looks easy enough to implement, and I would like to be able to use it. What are the expectations for new tests? Something like a Search test that would return multiple results without the Threshold but, with a threshold applied, returns fewer? What else?

And as far as updating .code-samples.meilisearch.yaml - is that something done internally, and you just want an example of it's usage added to the README of this repo?

curquiza commented 2 weeks ago

Something like a Search test that would return multiple results without the Threshold but, with a threshold applied, returns fewer? What else?

Would be perfect

And as far as updating .code-samples.meilisearch.yaml - is that something done internally, and you just want an example of it's usage added to the README of this repo?

Nope, I need you to update the code sample file of this repo with a new entry: search_parameter_reference_ranking_score_threshold_1, and put the same example than the one that has been linked in the issue, but not with curl but in dotnet 😊

danFbach commented 2 weeks ago

sorry, I missed the code-samples file since it wasn't shown in the solution explorer. 🤦‍♂️ lol Anyway, sending PR now.

curquiza commented 1 week ago

Trying to review your PR next week @danFbach thank you for your contributions ❤️