search

meilisearch / meilisearch-go

Golang wrapper for the Meilisearch API
https://www.meilisearch.com
MIT License
480 stars 81 forks source link

API doesn't take context.Context #462

Open Hades32 opened 11 months ago

Hades32 commented 11 months ago

every network operation in Go should take a context, so it can be cancelled and proper deadlines applied. This is only available in the task waiting api and even there in a non-standard manner

brunoocasali commented 11 months ago

Hi @Hades32, how are you?

I'm sure your right, and this is indeed a good refactor! But we will not have the time and human resources to make those changes.

Will you or someone watching this issue be able to implement it?

ysyneu commented 2 months ago

@brunoocasali @Hades32 Hi, how are you? I do not think it is easy to do this. The api call use the fasthttp library, which do not accept a context param. Do you have any better ideas?

curquiza commented 1 month ago

Hello @ysyneu I discussed with @brunoocasali but we don't have any better idea. We think the topic of the issue is still valuable despite it's not easy to do it as you said.

Any help of the community is welcome here ❤️