amit-ksh commented 5 months ago

Pull Request

Related issue

Fixes #1639

Add the SearchCutoffMsSetting type to Settings
Add new methods getSearchCutoffMs(), updateSearchCutoffMs() and resetSearchCutoffMs() to Index class
Add the tests for the newly added API

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

amit-ksh commented 5 months ago

⚠️ Note: Tests have not been successfully tested due to the unavailability of the search-cutoff-ms API.

curquiza commented 5 months ago

Thank you very much for your PR @amit-ksh

@mdubus will review your PR when she's available 😊 (next week probably)

mdubus commented 5 months ago

This looks great, thanks a lot @amit-ksh for taking care of this 🤩 👏