Currently timeout is done with a Promise.race, where we have two promises, one for the fetch and one for a setTimeout.
Using this solution will leave the request hanging and still consume bandwidth in the background and lower the maximum allowed concurrent requests being made while it's still in process. (https://stackoverflow.com/a/50101022)
Instead this timeout option should add an AbortSignal.timeout to the Request option's signal, if there isn't already one supplied. We should warn people, that if they're supplying this signal option themselves, their timeout will not work.
We could use AbortSignal.any to keep the same functionality as before, but it is not available in Node.js 18, and there's no polyfill for it either.
EDIT: Looks like AbortSignal.timeout has no polyfill either. In fact all of AbortController and AbortSignal isn't very well polyfilled, if at all. This would definitely have a big impact on compatibility, at least if one wishes to set a global timeout :\ . I really hate how the web is held back like this.
Currently timeout is done with a
Promise.race, where we have two promises, one for thefetchand one for asetTimeout. Using this solution will leave the request hanging and still consume bandwidth in the background and lower the maximum allowed concurrent requests being made while it's still in process. (https://stackoverflow.com/a/50101022)https://github.com/meilisearch/meilisearch-js/blob/cd61a8c14e9897c975ef2176bf5e6c56d15621f3/src/http-requests.ts#L177-L208
Instead this
timeoutoption should add anAbortSignal.timeoutto theRequestoption'ssignal, if there isn't already one supplied. We should warn people, that if they're supplying thissignaloption themselves, theirtimeoutwill not work.We could use
AbortSignal.anyto keep the same functionality as before, but it is not available in Node.js 18, and there's no polyfill for it either.EDIT: Looks like
AbortSignal.timeouthas no polyfill either. In fact all ofAbortControllerandAbortSignalisn't very well polyfilled, if at all. This would definitely have a big impact on compatibility, at least if one wishes to set a globaltimeout:\ . I really hate how the web is held back like this.