search

meilisearch / meilisearch-js

JavaScript client for the Meilisearch API
https://www.meilisearch.com
MIT License
703 stars 85 forks source link

Update `yarn` #1664

Open flevi29 opened 1 month ago

flevi29 commented 1 month ago

Currently this repository is using yarn classic.

One day, perhaps not too long from now, it will be deprecated for good, it says on the install page.

image

There are benefits to upgrading.

However the new version is to be managed through corepack. In my opinion the best way forward is to change actions/setup-node@v4 so that it no longer installs yarn globally, but rather enables corepack. https://github.com/meilisearch/meilisearch-js/issues/1664#issuecomment-2138804906

[!IMPORTANT] This will (theoretically, but I am 99% sure) not impact the rest of the JS repositories, as enabling corepack means that as soon as yarn or pnpm is entered into the command line, corepack installs it (if it isn't already installed), and then executes it. (I'm not sure why, but by default it installs Yarn classic, so it's fine)

Read more about upgrading to the latest Yarn: https://yarnpkg.com/getting-started/install

Migration should be very simple: https://yarnpkg.com/migration/guide#migration-steps

flevi29 commented 1 month ago

Okay, I had some misconceptions. I thought actions/setup-node was a Meilisearch custom script, but it's entirely out of your hands. The approach will be a little different it seems.

https://github.com/actions/setup-node/issues/480 https://github.com/actions/setup-node/pull/482 https://github.com/actions/setup-node/pull/651

It seems like they're not entirely into Corepack, because it's experimental, meanwhile Yarn wants you to use Corepack, so I'm not sure what's going on here. Seems like no one can agree on anything, classic JavaScript community.