meilisearch / meilisearch-js

JavaScript client for the Meilisearch API

https://www.meilisearch.com

MIT License

703 stars 85 forks source link

Add rankingScoreThreshold in search #1669

Closed the-sinner closed 3 weeks ago

the-sinner commented 3 weeks ago

Pull Request

Related issue

Fixes #1665

What does this PR do?

Add rankingScoreThreshold in search

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

the-sinner commented 3 weeks ago

I have added the error code invalid_search_ranking_score_threshold in types.ts. Is it fine ?

the-sinner commented 3 weeks ago

i have added the other error code as well. As for the style-check CI, it is running the yarn style, i have run the same command on my local, but it is showing that All matched files use Prettier code style!. I also tried running yarn style:fix as per Contributing.md, but still showing no changes.

curquiza commented 3 weeks ago

i have added the other error code as well. As for the style-check CI, it is running the yarn style, i have run the same command on my local, but it is showing that All matched files use Prettier code style!. I also tried running yarn style:fix as per Contributing.md, but still showing no changes.

Checking on my side now... Same as you I have no issue. I really don't understand what is happening here 😅

curquiza commented 3 weeks ago

Finally found the issue! merging!!