search

meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

Enabling Ingress Requires Port Override in Config #102

Closed kacy closed 2 years ago

kacy commented 2 years ago

Description In the event that an end developer wants to enable ingress, they also have to override the Service Port to port 80 since it's hardcoded in the template.

I would have opened a PR, but I'm not sure how the maintainers want to address it. We could tackle it in documentation, assume port 80 on the service port, or alter the ingress template to support the Helm variable.

Expected behavior What you expected to happen.

Current behavior Enabling the ingress flag results in the following error: Translation failed: invalid ingress spec: could not find port "&ServiceBackendPort{Name:,Number:80,}" in service "default/meilisearch"

Screenshots or Logs If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

alallema commented 2 years ago

Hi @kacy, Thank you for raising this issue! Indeed, this is not practical at all. I think the best solution is to allow the Helm template to set a variable with the default value at 7700. If you still want to open a PR to fix this it would be so great ❤️

kacy commented 2 years ago

Sure thing. I made the change here https://github.com/meilisearch/meilisearch-kubernetes/pull/103

Let me know if you have different thoughts. Thanks!