meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

feat: allow other ingress class than Nginx #122

Closed Tchoupinax closed 2 years ago

Tchoupinax commented 2 years ago

Pull Request

Hello :)

What does this PR do?

I test the ingress recently fixed (thank you for that) but I can't use it with traefik because of the ingressClassName set as default to nginx. I edited the chart to allow to dynamically change this value. :)

I set nginx as the default value but in my opinion not className should be the default value.

Anyway this improvement works for me.

Have a nice day!

Tchoupinax commented 2 years ago

You right! It is done :)

Have a nice day

alallema commented 2 years ago

bors merge

bors[bot] commented 2 years ago

Build succeeded:

Tchoupinax commented 2 years ago

Thank you for your reactivity again!