meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests

https://www.meilisearch.com

MIT License

212 stars 59 forks source link

ServiceMonitor resource for Prometheus scraping #153

Closed nlamirault closed 1 year ago

nlamirault commented 1 year ago

Pull Request

Related issue

#3523

What does this PR do?

Creates a ServiceMonitor Kubernetes resources.

Prometheus metrics must be enabled using the --experimental-enable-metrics CLI argument

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

brunoocasali commented 1 year ago

@alallema I think this PR will be necessary to the adoption of the new experimental feature https://github.com/meilisearch/meilisearch/issues/3523

So what I suggest you to do is:

[x] Fix parameters list like you suggested to the contributor
[x] Add comments and point to the engine issue regarding this experimental feature.
[x] Add support to Authorization token when a master key protects the instance.

alallema commented 1 year ago

Hi @nlamirault, Thank you so much for continuing to update your code each time ❤️ . I didn't forget you. I will finish by merging your PR, I just need to check some stuff before and I still don't have time to do it, but I will. Thank you so much for your patience 😊

alallema commented 1 year ago

Hi @nlamirault, Sorry to come back to this PR so late. I finally checked it. Rather than using the CLI command --experimental-enable-metrics, would it be possible to add the MEILI_EXPERIMENTAL_ENABLE_METRICS: "false" parameter to the environment variables and then if {{- if.Values.serviceMonitor.enabled -}} set it as (eq.Values.environment.MEILI_EXPERIMENTAL_ENABLE_METRICS "true") I'm not an expert, so I'd like your opinion. I can implement it in a subsequent PR if it's annoying. Thank you 😊

alallema commented 1 year ago

bors merge

meili-bors[bot] commented 1 year ago

Build succeeded:

meili-bot commented 1 year ago

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle? If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂 Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198