meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

Upgrading link leads to 404 #167

Closed pat-s closed 1 year ago

pat-s commented 1 year ago

The upgrading link shown leads to a 404

│ Error: Your database version (1.0.0) is incompatible with your current engine version (1.1.1).                                                                   │
│ To migrate data between Meilisearch versions, please follow our guide on https://docs.meilisearch.com/learn/update_and_migration/updating.html. 

https://www.meilisearch.com/docs/learn/update_and_migration/updating.html.

alallema commented 1 year ago

Hi @pat-s, Thanks for bringing this up, but for me the link on the answer is not broken. Where did you find the second one?

pat-s commented 1 year ago

The link I posted in OP leads to

image

alallema commented 1 year ago

The link I posted in OP leads to

Yes, I can see that, but where did you find it? Because it is not coming from the error message, does it? This way I know where we have to fix it because I'm not sure this one should work

pat-s commented 1 year ago

It comes from the link posted in OP.

brunoocasali commented 1 year ago

Actually @pat-s, if we use the link coming from the error message:

Error: Your database version (1.0.0) is incompatible with your current engine version (1.1.1).
To migrate data between Meilisearch versions, please follow our guide on https://docs.meilisearch.com/learn/update_and_migration/updating.html.

It does redirect.

pat-s commented 1 year ago

The following does not: https://www.meilisearch.com/docs/learn/update_and_migration/updating.html

and my browser redirects to the www subdomain first when I click on it.

brunoocasali commented 1 year ago

The following does not: https://www.meilisearch.com/docs/learn/update_and_migration/updating.html

and my browser redirects to the www subdomain first when I click on it.

Yes, but that's the thing we do not understand each other. I know this link: https://www.meilisearch.com/docs/learn/update_and_migration/updating.html does not work, but where does it come from?

pat-s commented 1 year ago

Ah!

I get redirected from https://docs.meilisearch.com/learn/update_and_migration/updating.html -> https://www.meilisearch.com/docs/learn/update_and_migration/updating.html when clicking on the URL in my browser (Chromium 112.0.5615.137).

alallema commented 1 year ago

Hi @pat-s, Do you still have a redirect from https://docs.meilisearch.com/learn/update_and_migration/updating.html to the wrong site? Maybe the problem comes from your cache because it should not be the case:

curl -s -L -D - https://docs.meilisearch.com/learn/update_and_migration/updating.html -o /dev/null -w '%{url_effective}'
HTTP/2 301
date: Tue, 09 May 2023 13:32:23 GMT
content-length: 0
location: https://www.meilisearch.com/docs/learn/update_and_migration/updating
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=s%2BRJ7vlRLO0hvqJFAo3qJFLMazho9hEuXiDcRxJgkx%2Bpr%2BDpNr3n6zVPHumNo4B4ZThPJ1Zbc4sFJKcko40nnr5RJf9G%2BFTX768wqRkEW77gYDxsBdTQ1ufL7hs72kjLGBnDYfGKeh%2FabMUmjDNiEQS37Q%3D%3D"}],"group":"cf-nel","max_age":604800}
nel: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
server: cloudflare
cf-ray: 7c4a4ee72a492a07-CDG
alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400

HTTP/2 200
age: 38
cache-control: public, max-age=0, must-revalidate
content-type: text/html; charset=utf-8
date: Tue, 09 May 2023 13:31:45 GMT
etag: "p1bpkmjdb08uxv"
server: Vercel
strict-transport-security: max-age=63072000
vary: RSC, Next-Router-State-Tree, Next-Router-Prefetch
x-matched-path: /docs/learn/update_and_migration/updating
x-powered-by: Next.js
x-vercel-cache: HIT
x-vercel-id: cdg1::iad1::wjbjb-1683639143587-94eac28ba780
content-length: 413357

https://www.meilisearch.com/docs/learn/update_and_migration/updating
pat-s commented 1 year ago

Ahh I think I've spotted the issue. In the OP you see that the . gets appended to the URL and then some weird redirection happens. If I just click the link in my terminal, the dot gets appended and you almost don't notice that.

Maybe it's safer remove the period at the end of the sentence. Not sure if it's a terminal issue or something else but I guess the safest would be to remove the dot 😃️

404: https://docs.meilisearch.com/learn/update_and_migration/updating.html. 200: https://docs.meilisearch.com/learn/update_and_migration/updating.html

But could it be that you also changes something? Or maybe it was my cache but usually I try something like this in private windows. But can't recall anymore...

alallema commented 1 year ago

In fact if you look carefully it has even a .html at the end that is redirected without, so if you copy with the dot it will not work and redirect to: https://www.meilisearch.com/docs/learn/update_and_migration/updating Thank you for closing it