meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

Add VPC to k8s manifest (change default to persistent - true) #200

Closed zamai closed 8 months ago

zamai commented 1 year ago

Pull Request

The plain k8s manifest (not the HELM version), does not have PVC for the kube stateful set. This PR adds it for the next developer who wants to grab manifest for working meilisearch without using helm.

Related issue

Related issue:, https://github.com/meilisearch/meilisearch-kubernetes/issues/159

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

Thank you so much for contributing to Meilisearch!

zamai commented 1 year ago

@meilisearch sync-manifest

brunoocasali commented 1 year ago

Hey @zamai can you check the files changed? It is empty :)

zamai commented 1 year ago

@brunoocasali I figured that manifest is generated from helm charts, and I saw that persistence is turned off by default.

I suggest switching it to true by default, so that production scenario (where you defiantly want your search data to persist after pod restart) is the default.

brunoocasali commented 11 months ago

Hi @zamai can you update the chart version to v0.4.0? Since you changed a default configuration the chart linters are complaining about that. We can merge it after that!

zamai commented 11 months ago

@meilisearch sync-manifest

zamai commented 11 months ago

@brunoocasali updated the PR

brunoocasali commented 11 months ago

I can't figure out why the CI does not run 😬

meili-bors[bot] commented 11 months ago

Build failed: