Use deployment instead of statefulset

meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests

https://www.meilisearch.com

MIT License

212 stars 59 forks source link

Use deployment instead of statefulset #23

Closed mehdicopter closed 3 years ago

mehdicopter commented 3 years ago

Create new labels and templates
Add possibility to create service account or not
Use deployment instead of statefulset
Add Horizontal Pod Autoscaling

mehdicopter commented 3 years ago

We could still attach an existing PVC to the deployment and set the number of replicas to 1 ?

renehernandez commented 3 years ago

We could still attach an existing PVC to the deployment and set the number of replicas to 1?

Using a statefulset have advantages beyond this:

If the StatefulSet is deleted or scaled down, the associated volume will be preserved, which is important in the case of the database
When Meilisearch supports multiple replicas, then the ordering of Pod during creation and deletion provided by the StatefulSet may be important for some initialization and cleanup procedures.

renehernandez commented 3 years ago

Also, this kind of changes should have been discussed first in a new issue, instead as part of a PR.

mehdicopter commented 3 years ago

You are right. I'll close this and create an other PR just for templating then. Thanks !

eskombro commented 3 years ago

Hi @mehdicopter !

Thanks for your contribution. Indeed it would be more interesting to have a discussion in an issue as @renehernandez points out! But glad to see your interest, and always interested in any feedback!

FYI in MeiliSearch roadmap, the Core Team is working on High Availability which will enable us soon to have a consistent replication policy, and we will find the best way to fit this in Kubernetes! As for now, it is not possible to make several MeiliSearch instances use the same DB, which makes replication a little bit tricky indeed, and so we are more into a single stateful deployment situation :)