meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests

https://www.meilisearch.com

MIT License

212 stars 59 forks source link

Closed acelinkio closed 1 month ago

acelinkio commented 3 months ago

Pull Request

N/A

Sets the default storageClass value to align with documentation beside it. Requires one less variable be defined for a quick setup.

Please check if your PR fulfills the following requirements:

[X ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[X] Have you read the contributing guidelines?
[X] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

brunoocasali commented 3 months ago

@meilisearch sync-manifest

brunoocasali commented 3 months ago

I was not aware of the ~ tilde usage in YML, it means null right?

And I think the change makes sense as well

acelinkio commented 3 months ago

correct. ~ is shorthand for null. link to yaml source http://yaml.org/spec/1.2/spec.html#id2805071

acelinkio commented 3 months ago

I see the tests failed. Looks like it expects a version to be bumped. I am down to increment it, but figured that would be best to a release process.

brunoocasali commented 2 months ago

Hi @acelinkio can you update the chart version? So I can merge this PR?

acelinkio commented 2 months ago

Updated version to 0.9.1

brunoocasali commented 1 month ago

@meilisearch sync-manifest

brunoocasali commented 1 month ago

bors merge

meili-bors[bot] commented 1 month ago

Build succeeded: