meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

feat: handle correctly when replica count is set to 0 #238

Closed Tchoupinax closed 3 days ago

Tchoupinax commented 1 month ago

Hello,

This evolution brings the ability to set the replica count to zero. There is an unexpected behaviour in helm that does not allow it as we would expect it. My current usage of putting replica count to zero is for https://github.com/acouvreur/sablier

Thank for your work!

brunoocasali commented 1 month ago

@meilisearch sync-manifest

brunoocasali commented 1 month ago

Hey @Tchoupinax can you fix the conflicts?

brunoocasali commented 1 month ago

@meilisearch sync-manifest

Tchoupinax commented 1 month ago

Hey @Tchoupinax can you fix the conflicts?

Sorry just got your message. It's done now!

brunoocasali commented 2 weeks ago

bors try

meili-bors[bot] commented 2 weeks ago

try

Build failed:

brunoocasali commented 2 weeks ago

@meilisearch sync-manifest

brunoocasali commented 2 weeks ago

bors merge

meili-bors[bot] commented 2 weeks ago

Build failed:

brunoocasali commented 2 weeks ago

@meilisearch sync-manifest

brunoocasali commented 2 weeks ago

bors merge

meili-bors[bot] commented 2 weeks ago

Build failed:

brunoocasali commented 2 weeks ago

@meilisearch sync-manifest

brunoocasali commented 2 weeks ago

bors merge

meili-bors[bot] commented 2 weeks ago

Build failed:

brunoocasali commented 2 weeks ago

@meilisearch sync-manifest

brunoocasali commented 3 days ago

bors merge

meili-bors[bot] commented 3 days ago

Build failed:

brunoocasali commented 3 days ago

Hey @Tchoupinax, I was not able to understand what's missing here, I agree with your PR, but I don't have time to investigate the issue happening in the CI.

I'm going to close this PR, feel free to reopen if you want to fix it :)