meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

chore(statefulset): customizable initialDelaySeconds and periodSecond… #32

Closed HelmutLety closed 3 years ago

HelmutLety commented 3 years ago

…s for livenessProbe and readinessProbe

HelmutLety commented 3 years ago

Does the failing helm-test has something to do with #31 ? Maybe you know @eskombro

eskombro commented 3 years ago

@HelmutLety Probably, let me check this

eskombro commented 3 years ago

bors try

bors[bot] commented 3 years ago

try

Build succeeded:

eskombro commented 3 years ago

@HelmutLety

Thanks for the patience! It was indeed caused by #31 and this problem is fixed now by #34

HelmutLety commented 3 years ago

Super nice, thanks @eskombro !

eskombro commented 3 years ago

A pelasure!

Let me know when you feel everything is ready!

HelmutLety commented 3 years ago

I feel it is ready

eskombro commented 3 years ago

Thanks a lot for being so reactive and fast!

There have been some changes in master since you created the branch but I think this shouldn't cause any conflict.

Bors try

bors[bot] commented 3 years ago

try

Build succeeded:

eskombro commented 3 years ago

This PR look good to me!

Thanks again @HelmutLety !!!! 🎉

eskombro commented 3 years ago

Bors merge

bors[bot] commented 3 years ago

Build succeeded: