search

meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

Add GitHub releases to CI #37

Closed eskombro closed 3 years ago

curquiza commented 3 years ago

Hello!

A release drafter is useful when the release creation is done via the GitHub interface: you accumulate PRs and then, when you want, you trigger the release creation. Currently, in this package, it looks like each PR = a new release because the version changes in the chart file.

We could create releases on GitHub too, but the draft is not necessary: instead, we should configure a bot/hook that automatically creates a GitHub release after each PR merge when the version changes in the chart file.

Is it ok for you or do I miss something?

eskombro commented 3 years ago

As for now, we are only handling Helm charts and manifests, so this seems ok to me.

But depending on its evolution, the Helm chart version won't necessarily reflect meilisearch-kubernetes version in the future.

So maybe having GitHub releases make sense. As for now, we can totally automate them (in the exact way you suggest) and make them correspond to the version we are defining on the charts, and if this evolves we can reconsider!

eskombro commented 3 years ago

@curquiza I changed the title of this issue, feel free to modify if you want it to be more specific or reflect something different :)

curquiza commented 3 years ago

In the other SDKs, we automate in CIs:

Sorry for my noob question, but this repo does not seem to have any publishment of the package to any platform, am I right? And for the moment, there is no need to update the release draft since there is no real release process except "a new PR merged is a new release". So what does Add GitHub releases to CI mean? We need to decide the new way of releasing before automating anything in a CI. But maybe I missed a point...

The first step to avoiding confusion would have been to add a description to the issue 😉 But I don't recommend doing this now: this would add confusion and my answer is already weird since you renamed the issue. Maybe open a new one with a minimal description about what you mean by "Add GitHub releases to CI" (a new release process?) would be a better idea 😄

I like this kind of improvement anyway! This will make this package better for contribution!! And sorry if I missed something and my message made more confusion.

eskombro commented 3 years ago

Thanks @curquiza

The Helm chart publish process to an "official" repository is discussed here and no decision has been made, but is an interesting one. I think that this is the most important point to discuss now, and I realize I am kind of adding just unnecessary noise with this new issue, so I think the best option is to find a solution to that discussion, and then think about this.

The first step to avoiding confusion would have been to add a description to the issue 😉 But I don't recommend doing this now.

100% agreed!

curquiza commented 3 years ago

Ah thanks, this was the kind of discussion I was looking for when writing my comment!!! 👍 Awesome!