meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

Increase default health check delay values: InitialDelaySeconds for readinessProbe and livenessProbe #54

Closed eskombro closed 3 years ago

eskombro commented 3 years ago

By default, the values of InitialDelaySeconds for readinessProbe and livenessProbe were set to 0. periodSeconds was set to 10.

  1. This means that the health checks are done as soon as the container starts running. If adding this health check is best practice, it is also good to let some time for the application to start running properly before doing the health check, since a bad response can be read by kubernetess cluster as a failure and it will restart the container.
  2. A period of 10 seconds between every health check seems too short for most use-cases. A check every minute seems more appropriate as a default.

These values are of course modifiable on the values.yaml file, but having more appropriate values seem better for most use-cases and for users who are not tuning these parameters.

eskombro commented 3 years ago

Thanks @curquiza

Bors merge

bors[bot] commented 3 years ago

Build succeeded: