search

meilisearch / meilisearch-kubernetes

Meilisearch on Kubernetes Helm charts and manifests
https://www.meilisearch.com
MIT License
212 stars 59 forks source link

Add custom labels to values and all templates #79

Closed allangalera closed 3 years ago

allangalera commented 3 years ago

Description Add the possibility to customize the labels on all templates so that it can improve governance. On the company I work we use these values to identify which squad, csot center, etc.

Basic example Add a customLabels: {} on values.yaml and add to all labels on templates.

I forked the repo be more clear:

values.yaml templates

I'm not an expert on this matter so if I made any silly mistake forgive me. I hope my solution is generic enought. I wanted so that any one can benefit from this change 😸

alallema commented 3 years ago

Hi @allangalera, Thanks for the proposal. Indeed this could be really useful. If you want to create a PR I will be great to review it and merge it. It will obviously be taken into account in the Hackoberfest if you participate. If you need help or if you don't want to create a PR it's fine too. Have a nice day and thanks again

allangalera commented 3 years ago

Hi @alallema I can open the PR. It's ready. I just need permisison to create a branch and open the PR 👍

Have a nice day and thanks for the fast and kind response 😸

alallema commented 3 years ago

Hi @allangalera, We don't give permission to the contributors on the repo. You can see here how to contribute! If you have any issues don't hesitate to ask 😊

allangalera commented 3 years ago

Hi @alallema. Oh sorry! My bad 🤦 Here is the link to the PR Tell me if there is anything wrong so that I can change 😸