search

meilisearch / meilisearch-laravel-scout

MeiliSearch integration for Laravel Scout
https://github.com/meilisearch/MeiliSearch
MIT License
465 stars 43 forks source link

added facetAttributes in Model #109

Closed bsormagec closed 3 years ago

bsormagec commented 3 years ago

I try to add quickly facetAttributes option to models to use it for filtering on product or something searching.

curquiza commented 3 years ago

Hello @bsormagec,

Thanks a lot for your PR and your involvement! :) However, this PR includes a behavior we don't want to handle for the moment. Indeed, as described in this issue I've just created (you're not the first one who are not aware of this) I explain we want to stay completely compliant with the original laravel/scout usage for the moment. The way to update settings is described in our wiki here I'm closing this PR but thank you anyway! It made me create the issue I linked 😊

bsormagec commented 3 years ago

thank you @curquiza i just didn't know another way to do it, that's my fault. Now I see a way to do it another way :)