In looking at #962 I noticed that the index_with_documents_and_vectors fixture was not working as expected and therefore the test_vector_search test was not testing what was expected. Because only one document had vectors the document addition task was failing and no documents were added to the index. So test_vector_search was returning no hits because there were no documents in the index. This updates the fixutre to add vectors to all documents, and updates the test to pass with the new results.
Related issue
Fixes #
What does this PR do?
Fixes the test_vector_search test.
PR checklist
Please check if your PR fulfills the following requirements:
[ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[ ] Have you read the contributing guidelines?
[ ] Have you made sure that the title is accurate and descriptive of the changes?
Thank you so much for contributing to Meilisearch!
meili-bors[bot]
commented
5 months ago
Pull Request
In looking at #962 I noticed that the
index_with_documents_and_vectorsfixture was not working as expected and therefore thetest_vector_searchtest was not testing what was expected. Because only one document had vectors the document addition task was failing and no documents were added to the index. Sotest_vector_searchwas returning no hits because there were no documents in the index. This updates the fixutre to add vectors to all documents, and updates the test to pass with the new results.Related issue
Fixes #
What does this PR do?
test_vector_searchtest.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!