meilisearch / meilisearch-python

Python wrapper for the Meilisearch API

https://meilisearch.com

MIT License

459 stars 85 forks source link

Add proximityPrecision setting #971

Closed the-sinner closed 4 months ago

the-sinner commented 4 months ago

Pull Request

Related issue

Fixes #916

What does this PR do?

Add proximityPrecision setting

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

the-sinner commented 4 months ago

@sanders41 pylint is falling because the index.py has more than 2000 lines. Should i disable this pylint warning like https://github.com/meilisearch/meilisearch-python/blob/1b76f36212445bac854aa8fd082e559dc5fc7483/meilisearch/index.py#L27

or should i add the code to another file ?

sanders41 commented 4 months ago

@sanders41 pylint is falling because the index.py has more than 2000 lines. Should i disable this pylint warning like meilisearch-python/meilisearch/index.py

It makes the most sense to keep the code together like you have it so go ahead and disable the rule as you suggested.

meili-bors[bot] commented 4 months ago

Build failed:

integration-tests (3.8)

curquiza commented 4 months ago

bors merge

meili-bors[bot] commented 4 months ago

Build succeeded: