meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails
https://www.meilisearch.com
MIT License
295 stars 47 forks source link

Changed camel case keywords to snake case #278

Closed jason-hobbs closed 1 year ago

jason-hobbs commented 1 year ago

Was getting warnings in tests and logs like so: Non-conforming attributes: searchableAttributes, sortableAttributes Attributes will be expected to be snake_case in future versions of Meilisearch Ruby.

Changed all instances of camel case to snake case to make warnings go away and to resolve the deprecations.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3f41be9) 88.58% compared to head (8753e2f) 88.58%.

:exclamation: Current head 8753e2f differs from pull request most recent head d4c6afa. Consider uploading reports for the commit d4c6afa to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ======================================= Coverage 88.58% 88.58% ======================================= Files 10 10 Lines 648 648 ======================================= Hits 574 574 Misses 74 74 ``` | [Files Changed](https://app.codecov.io/gh/meilisearch/meilisearch-rails/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meilisearch) | Coverage Δ | | |---|---|---| | [lib/meilisearch-rails.rb](https://app.codecov.io/gh/meilisearch/meilisearch-rails/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meilisearch#diff-bGliL21laWxpc2VhcmNoLXJhaWxzLnJi) | `90.36% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

meili-bors[bot] commented 1 year ago

Build failed:

meili-bors[bot] commented 1 year ago

Build succeeded: