meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails
https://www.meilisearch.com
MIT License
308 stars 47 forks source link

Add return value to ms_index! #289

Closed ellnix closed 11 months ago

ellnix commented 1 year ago

Pull Request

Related issue

Fixes #271

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

I'm new to this project, so I tried to keep the solution as unopinionated as possible. Please feel free to suggest changes to the implementation.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e5ad4d1) 89.04% compared to head (87dcae7) 89.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ======================================= Coverage 89.04% 89.04% ======================================= Files 10 10 Lines 657 657 ======================================= Hits 585 585 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ellnix commented 11 months ago

@brunoocasali sorry for being inactive this month, this and the other PRs should be ready to merge if you agree with the changes.

brunoocasali commented 11 months ago

Hey @ellnix I asked some questions in the last review, could you check them?

ellnix commented 11 months ago

bors merge

meili-bors[bot] commented 11 months ago

Build succeeded:

mech commented 11 months ago

Wonderful!