meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails
https://www.meilisearch.com
MIT License
295 stars 47 forks source link

Warn when you make missing attribute searchable #293

Closed ellnix closed 10 months ago

ellnix commented 11 months ago

Pull Request

Related issue

Fixes #168

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

ellnix commented 11 months ago

I believe I fixed the issues suggested, I had made some really strange decisions on this PR.

I also removed one place where I used the new ruby 3 method definition syntax which would have broken compatibility with ruby 2.x in the test suite.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ef5d96c) 88.58% compared to head (007d085) 88.73%.

:exclamation: Current head 007d085 differs from pull request most recent head 645cf76. Consider uploading reports for the commit 645cf76 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #293 +/- ## ========================================== + Coverage 88.58% 88.73% +0.15% ========================================== Files 10 10 Lines 648 657 +9 ========================================== + Hits 574 583 +9 Misses 74 74 ``` | [Files](https://app.codecov.io/gh/meilisearch/meilisearch-rails/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meilisearch) | Coverage Δ | | |---|---|---| | [lib/meilisearch-rails.rb](https://app.codecov.io/gh/meilisearch/meilisearch-rails/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meilisearch#diff-bGliL21laWxpc2VhcmNoLXJhaWxzLnJi) | `90.53% <100.00%> (+0.17%)` | :arrow_up: | | [lib/meilisearch/rails/pagination.rb](https://app.codecov.io/gh/meilisearch/meilisearch-rails/pull/293?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meilisearch#diff-bGliL21laWxpc2VhcmNoL3JhaWxzL3BhZ2luYXRpb24ucmI=) | `93.75% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brunoocasali commented 11 months ago

I believe I fixed the issues suggested, I had made some really strange decisions on this PR.

I also removed one place where I used the new ruby 3 method definition syntax which would have broken compatibility with ruby 2.x in the test suite.

Nice, as soon you fix them we will be good to go, thanks a lot for your effort @ellnix!

ellnix commented 10 months ago

@brunoocasali this should be good to go.

ellnix commented 10 months ago

bors merge

meili-bors[bot] commented 10 months ago

Build succeeded: