Closed ellnix closed 10 months ago
I believe I fixed the issues suggested, I had made some really strange decisions on this PR.
I also removed one place where I used the new ruby 3 method definition syntax which would have broken compatibility with ruby 2.x in the test suite.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
ef5d96c
) 88.58% compared to head (007d085
) 88.73%.:exclamation: Current head 007d085 differs from pull request most recent head 645cf76. Consider uploading reports for the commit 645cf76 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I believe I fixed the issues suggested, I had made some really strange decisions on this PR.
I also removed one place where I used the new ruby 3 method definition syntax which would have broken compatibility with ruby 2.x in the test suite.
Nice, as soon you fix them we will be good to go, thanks a lot for your effort @ellnix!
@brunoocasali this should be good to go.
bors merge
Pull Request
Related issue
Fixes #168
What does this PR do?
#logger
method toMeiliSearch::Rails
which is similar to Rails having its ownRails#logger
PR checklist
Please check if your PR fulfills the following requirements: