meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails
https://www.meilisearch.com
MIT License
308 stars 47 forks source link

Make integration_spec randomizable #296

Closed ellnix closed 1 year ago

ellnix commented 1 year ago

Pull Request

Related issue

Fixes #115

PR checklist

Please check if your PR fulfills the following requirements:

Notes (please read)

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fc40e59) 88.73% compared to head (8547b03) 89.04%.

:exclamation: Current head 8547b03 differs from pull request most recent head 8b3afd3. Consider uploading reports for the commit 8b3afd3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #296 +/- ## ========================================== + Coverage 88.73% 89.04% +0.30% ========================================== Files 10 10 Lines 657 657 ========================================== + Hits 583 585 +2 + Misses 74 72 -2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/meilisearch/meilisearch-rails/pull/296/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meilisearch)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ellnix commented 1 year ago

@brunoocasali Rebased, and I think I addressed all of the feedback.

ellnix commented 1 year ago

bors merge

meili-bors[bot] commented 1 year ago

Build failed:

ellnix commented 1 year ago

bors merge

meili-bors[bot] commented 1 year ago

Build succeeded: