meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails
https://www.meilisearch.com
MIT License
308 stars 47 forks source link

Update CI to use Ubuntu 22.04 #308

Closed ellnix closed 1 year ago

ellnix commented 1 year ago

Related issue

Fixes #306

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fe14754) 88.58% compared to head (6b93f1b) 88.58%. Report is 1 commits behind head on main.

:exclamation: Current head 6b93f1b differs from pull request most recent head d67a9a9. Consider uploading reports for the commit d67a9a9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #308 +/- ## ======================================= Coverage 88.58% 88.58% ======================================= Files 10 10 Lines 648 648 ======================================= Hits 574 574 Misses 74 74 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ellnix commented 1 year ago

Thank you for the PR @ellnix

Can you update the ubuntu version everywhere in the CI manifest files to avoid future maintenance (when 20.04 will be deprecated)?

Sure thing, for some reason I assumed it would just grab that setting everywhere. I'm not familiar with github actions, which is why I let that issue sit for so long.

ellnix commented 1 year ago

Good for me, I let you merge if you are ok @ellnix

Oh, thanks. I am assuming I use bors in this case?

ellnix commented 1 year ago

bors merge

ellnix commented 1 year ago

For some reason bors does not like me and it's failing with 403 @curquiza

curquiza commented 1 year ago

@ellnix it's happening sometimes, merge manually in this case. I don't know what to do with this kind of issue 😓 It's an issue happening from time to time with bors