meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails

https://www.meilisearch.com

MIT License

295 stars 47 forks source link

Fix facet search error #320

Closed ellnix closed 7 months ago

ellnix commented 7 months ago

Pull Request

Related issue

Fixes #317

What does this PR do?

~~Updates SafeIndex to pass **opts along to methods defined on a MeiliSearch::Index~~
Ruby 2 is different in how it passes the last **options parameter so to maintain compatibility with it, I created a facet_search method on SafeIndex

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6a3c04b) 89.09% compared to head (38a422e) 89.15%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #320 +/- ## ========================================== + Coverage 89.09% 89.15% +0.06% ========================================== Files 10 10 Lines 660 664 +4 ========================================== + Hits 588 592 +4 Misses 72 72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

curquiza commented 7 months ago

@ellnix You can merge when you want, and same, do a new release when you want. We are available for review

brunoocasali commented 7 months ago

Did not see your message before @curquiza haha, I'm going to do this one, then @ellnix can follow do following ones!

meili-bors[bot] commented 7 months ago

Build succeeded: