Closed ellnix closed 4 months ago
Build failed:
I hate codecoverage, there is always something failing... 😅
Hi, will this be merged?
Hi, will this be merged?
I'm not familiar with Codecov (and don't have time to get familiar recently :smiling_face_with_tear:).
We have to wait for someone from Meilisearch staff who has the authority to merge this.
Invoking @brunoocasali here 🙏
I've regenerate the CODECOV_TOKEN let's see if that helps 😢
bors merge
Build failed:
@brunoocasali it still does not work 😢
Hi @ellnix can you take a look at the failing tests? Maybe the codecov issue will be gone as soon as we fix the tests.
Hi @ellnix can you take a look at the failing tests? Maybe the codecov issue will be gone as soon as we fix the tests.
@brunoocasali test regressions fixed, codecov is still bugging.
Look what I found in the docs https://github.com/codecov/codecov-action?tab=readme-ov-file#usage
So, I replaced it to use the arg instead of the env, didn't work. Then I added both, didn't work, then I tried to create my own branch without the fork didn't work either.
But, I ran out of time to fix it, so I made a commit removing the codecov.
Guess what? Even after removing the GithubAction, we still have the issue because we have an outdated version of the codec gem installed (I didn't remember we were using one).
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.22%. Comparing base (
9f71936
) to head (7c2465e
).:exclamation: Current head 7c2465e differs from pull request most recent head 30d5ed0. Consider uploading reports for the commit 30d5ed0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pull Request
Related issue
Fixes #352