search

meilisearch / meilisearch-rails

Meilisearch integration for Ruby on Rails
https://www.meilisearch.com
MIT License
295 stars 48 forks source link

Update Gem dependencies #354

Closed jeremylynch closed 1 month ago

jeremylynch commented 4 months ago

Meilisearch 0.27.1 adds support for the latest version of meilisearch (1.7.0), however this gem requires 0.26.0. Can we have the depdencies upgraded to allow Meilisearch 0.27.1? 

Because meilisearch-rails >= 0.10.2 depends on meilisearch ~> 0.26.0
  and Gemfile depends on meilisearch = 0.27.1,
  meilisearch-rails >= 0.10.2 cannot be used.
So, because Gemfile depends on meilisearch-rails = 0.12.0,
  version solving has failed.
brunoocasali commented 4 months ago

Hi @jeremylynch I just stumble upon your issue.

We are using the ~> 0.26.0 so it should already allow you to update your meilisearch-ruby and meilisearch-rails version, no?

ellnix commented 4 months ago

We are using the ~> 0.26.0 so it should already allow you to update your meilisearch-ruby and meilisearch-rails version, no?

~> only allows an update to the patch version, not the minor version.

From the bundler documentation:

gem "rails", "~> 4.0.0" # which is same as gem "rails", ">= 4.0.0", "< 4.1.0"
brunoocasali commented 4 months ago

Oh yeah, my bad! https://thoughtbot.com/blog/rubys-pessimistic-operator

@ellnix I'm ok if you raise the dependency to >= 0.26.0

ellnix commented 4 months ago

@ellnix I'm ok if you raise the dependency to >= 0.26.0

I think we should stick with ~> and updating the version manually. If I change the requirement to >=, someone might want to use ms-rails 0.14 as we intended it and end up with a much later of ms-ruby that may no longer be compatible.

In any case, should I PR this and also make a 0.13.1 release? (I feel like it would be better to update that on a minor version)

brunoocasali commented 4 months ago

In any case, should I PR this and also make a 0.13.1 release? (I feel like it would be better to update that on a minor version)

In my mind, we could always ignore the versions that are not compatible using != version or just increase the starting point, let's say meilisearch-ruby >= 0.30.0. And we always ask the users to be on the latest on both sides :D

But as you wish! I was trying to reduce the amount of work 😅

jeremylynch commented 3 months ago

Any update on this one?

jeremylynch commented 3 months ago

Any luck with this one?

ellnix commented 1 month ago

I believe this was implemented on #367