Remove ruby 3.0 & Upgrade codecov setup

meilisearch / meilisearch-ruby

Ruby SDK for the Meilisearch API

https://meilisearch.com

MIT License

198 stars 43 forks source link

Remove ruby 3.0 & Upgrade codecov setup #533

Closed brunoocasali closed 4 months ago

brunoocasali commented 4 months ago

Just a couple of maintenance stuff:

remove ruby 3.0 from the CI runs.
Upload codecov only from the ruby 3.3 execution
Remove codecov gem
Add simplecov-cobertura gem

curquiza commented 4 months ago

Putting breaking-change, as usual when we drop a support (to let user know and not only increase the patch)

meili-bors[bot] commented 4 months ago

Build succeeded:

brunoocasali commented 4 months ago

I don't think this is a breaking @curquiza because we will not change the gemspec. The users can still use the gem with ruby 3 s.required_ruby_version = '>= 3.0.0'

brunoocasali commented 4 months ago

So, under the CI, we can keep only the supported versions from the ruby core team, but for the user side, we still support their older version. What do you think?

ellnix commented 4 months ago

So, under the CI, we can keep only the supported versions from the ruby core team, but for the user side, we still support their older version. What do you think?

Can we really say we maintain something if we do not run our tests using it? Would be a bad look if there are issues with our "supported" versions that can only be caught by the users.