meilisearch / meilisearch-ruby

Ruby SDK for the Meilisearch API
https://meilisearch.com
MIT License
199 stars 44 forks source link

Update httparty requirement from ~> 0.17.1 to >= 0.17.1, < 0.23.0 #538

Closed dependabot[bot] closed 4 months ago

dependabot[bot] commented 5 months ago

Updates the requirements on httparty to permit the latest version.

Release notes

Sourced from httparty's releases.

v0.22.0

What's Changed

New Contributors

Full Changelog: https://github.com/jnunemaker/httparty/compare/v0.21.0...v0.22.0

Changelog

Sourced from httparty's changelog.

Changelog

All notable changes since 0.22 are documented in GitHub Releases.

0.21.0

0.20.0

Breaking changes

  • Require Ruby >= 2.3.0

Fixes

0.19.1

0.19.0

0.18.1

0.18.0

0.17.3

0.17.2 is broken jnunemaker/httparty#681

0.17.2

... (truncated)

Commits


You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (1875bac) to head (d6ad0a8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #538 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 677 677 ========================================= Hits 677 677 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bb commented 4 months ago

I approve this and request it to be merged and released. While meilisearch-ruby 0.27 and earlier allowed httparty from 0.17.1 to (including) 0.21.x, in #531 it was accidentally restricted to 0.17.x with x>=1 for meilisearch 0.28.0.

In the spirit of https://github.com/meilisearch/meilisearch-ruby/pull/530#issuecomment-2099016483, the version should be ~> 0.17 which would allow any 0.x. This was also mentioned in https://github.com/meilisearch/meilisearch-ruby/commit/79e6b0467f9189626c804387f6dfcc1078224850#commitcomment-143136367

I already started creating a PR (see commit here: https://github.com/bb/meilisearch-ruby/commit/dfbdcc72cf7ef1dde89c4437a57c2da384d94aeb) but noticed this PR just before submitting mine.

meili-bors[bot] commented 4 months ago

Build succeeded: