meilisearch / meilisearch-ruby

Ruby SDK for the Meilisearch API
https://meilisearch.com
MIT License
199 stars 44 forks source link

Fix weird error on global SDK CI from meilisearch/meilisearch #554

Closed brunoocasali closed 4 months ago

brunoocasali commented 4 months ago

We use to run a global CI with all the SDKs against the nightly build of meilisearch just to spot any potential error during the development phase of the engine team.

But this time, the error had nothing to do with their implementation; it only involved the ruby CI. The latest run was breaking in a weird way: https://github.com/meilisearch/meilisearch/actions/runs/9941341341/job/27460158817

Somehow, the time gem is explicitly required before using some methods like Time.parse. I say it is weird because we have the same configuration in this repo, and we don't have that error.

CC: @ellnix @curquiza

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (96a2ee4) to head (74b8dac).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #554 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 677 677 ========================================= Hits 677 677 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

meili-bors[bot] commented 4 months ago

Build failed:

curquiza commented 4 months ago

bors merge

meili-bors[bot] commented 4 months ago

Build failed:

curquiza commented 4 months ago

bors merge

meili-bors[bot] commented 4 months ago

Build succeeded: