search

meilisearch / meilisearch-rust

Rust wrapper for the Meilisearch API.
https://www.meilisearch.com
MIT License
361 stars 90 forks source link

Send documents as jsonlines #265

Open irevoire opened 2 years ago

irevoire commented 2 years ago

Description All the functions that create or update documents should send jsonlines instead of a JSON array.

Why That's faster to process by meilisearch and consumes less memory.

How Currently, the issue is that when we send a POST or PUT request in the SDK, it's automatically flagged as JSON. We need to update our internal to support JSON for the settings and jsonlines for the documents.

matthias-wright commented 2 years ago

I would like to work on this, is this issue still current? Can the meilisearch server already handle requests that send jsonlines?

irevoire commented 2 years ago

Hey @matthias-wright, yes thanks for your interest, this hasn't been implemented. Meilisearch can handle jsonlines IF you set the good content-type and only on the POST and PUT route 👍

postmeback commented 3 months ago

If https://github.com/meilisearch/meilisearch-rust/pull/417 was able to fix this, then please close it.