meilisearch / meilisearch-swift

Swift client for the Meilisearch API

https://www.meilisearch.com

MIT License

93 stars 26 forks source link

Fix-#363 'type should be enum' #375

Closed Dishant10 closed 1 year ago

Dishant10 commented 1 year ago

Pull Request

Related issue

Fixes #363

What does this PR do?

Makes the type variable an enum and all the cases are made as per the issue description.

PR checklist

Please check if your PR fulfills the following requirements:

[• ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[• ] Have you read the contributing guidelines?
[• ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Dishant10 commented 1 year ago

@brunoocasali can you please guide me what do I have to do in order to fix the other two failing tests. Thank you!!

Dishant10 commented 1 year ago

Any updates ? @brunoocasali Thank you!!

Dishant10 commented 1 year ago

Thank you! @brunoocasali this will help me a lot! I will fix these as soon as possible! Thank you!

Dishant10 commented 1 year ago

Hii @brunoocasali I'm sorry I was away for some time. I've made some changes, how can I test and get the messages on my local before raising a PR. ? Thank you!!

Dishant10 commented 1 year ago

I also had some doubts while fixing typing issues as you mentioned in the IndexesResults.swift file. So I want to test it locally first.

brunoocasali commented 1 year ago

Hii @brunoocasali I'm sorry I was away for some time. I've made some changes, how can I test and get the messages on my local before raising a PR. ? Thank you!!

Hi @Dishant10 good to see you here!

You can follow the instructions written here: https://github.com/meilisearch/meilisearch-swift/blob/main/CONTRIBUTING.md#development-workflow

brunoocasali commented 1 year ago

Closing due to inactivity!