meilisearch / meilisearch-swift

Swift client for the Meilisearch API

https://www.meilisearch.com

MIT License

93 stars 26 forks source link

Add typo-tolerance APIs #411

Closed Sherlouk closed 1 year ago

Sherlouk commented 1 year ago

Pull Request

Related issue

Fixes #282

What does this PR do?

Adds support for reading, updating, and resetting typo-tolerance preferences

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Sherlouk commented 1 year ago

Flagging the same kind of error here as other PR - I think CI itself might need an update as passing locally with up to date version.

I'll take a look into scripts and verify.

Sherlouk commented 1 year ago

As with the other PR, this was entirely my mistake. I've patched the tests, and ran all locally to verify behaviour.

I've done an extra force commit above as CI failed to download the MeiliSearch binary after 10s - this was nothing to do with my work. The force commit has prompted CI to try again, and has seemingly made it further this time.

Sherlouk commented 1 year ago

I would recommend waiting for #417 to be merged, then I'll rebase this PR on top of that. With the improvements made there it'll reduce the size of this.

curquiza commented 1 year ago

@Sherlouk can you rebase please? 😇

meili-bors[bot] commented 1 year ago

Canceled.

Sherlouk commented 1 year ago

Huge apologies, I did an empty commit in order to fix the failed build (which wasn't due to my code!).

curquiza commented 1 year ago

No worries!

curquiza commented 1 year ago

bors merge

meili-bors[bot] commented 1 year ago

Build succeeded: