Fix clippy error to add clippy job on Ci

[unvalley]

Related PR

This PR is for #673

What does this PR do?

• add Run Clippy job to CI (rust.yml)
• apply cargo clippy --fix command
• fix some cargo clippy error manually (but warnings still remain on tests)

PR checklist

Please check if your PR fulfills the following requirements:

• [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• [x] Have you read the contributing guidelines?
• [x] Have you made sure that the title is accurate and descriptive of the changes?

[curquiza]

@unvalley Sorry, since we merged https://github.com/meilisearch/milli/pull/665 related to your work, you have a lot of git conflict. Can you fix them? I would keep at least the addition of the CI in your PR, which is really useful for us! Thank you 🙏

[unvalley]

@curquiza No problem, I'll fix the conflicts!

[unvalley]

@curquiza I've fixed conflicts by accepting all current (main) change. The last commit passes cargo clippy (but as I described, there are still warnings). Please take a look?

[curquiza]

For me it's ok for the CI side @ManyTheFish (or some else in @meilisearch/core-team) I let you review the code base part before merging

[curquiza]

bors try

[bors[bot]]

try

Build failed:

• Run Rustfmt

[curquiza]

@unvalley looks like the CIs are all failing, could you fix this before the core team review your PR?

[curquiza]

bors try

[bors[bot]]

try

Build failed:

• Run Rustfmt

[unvalley]

I have to fix all warnings to pass the CI.

env:
  CARGO_TERM_COLOR: always
  RUSTFLAGS: "-D warnings"

The RUSTFLAGS -D warnings denies all warnings and this pr has warnings by clippy now.

[curquiza]

@unvalley, how big is it. Do you want to provide another PR before merging this one fixing all the conflicts?

[unvalley]

@curquiza There are 24 clippy errors (by -D warnings). So, that's not too big. I work to fix the errors in this PR and I use #allow(clippy::lint) in some places to merge this PR asap.

[curquiza]

@unvalley thank you very much this is really appreciated 🙏

[unvalley]

@curquiza Could you try bors? :pray: I've checked that cargo clippy -- -D warnings finished successfully on my machine.

[curquiza]

bors try

[bors[bot]]

try

Build failed:

• Run Rustfmt

[unvalley]

bors try

[bors[bot]]

:lock: Permission denied

Existing reviewers: click here to make unvalley a reviewer

[unvalley]

it might be bors ready.

[unvalley]

668 is may be overlapped changes with this #659 .

but reducing #659 diff is useful for reviewers imo😺

[curquiza]

Ok @unvalley thanks for letting me know! We will merge #668 first

[unvalley]

Thanks for running CI. I need to align the clippy outputs on CI and on my machine.

[curquiza]

@unvalley https://github.com/meilisearch/milli/pull/668 has been merged! Can you fix the merge conflicts? 😇

[ehiggs]

Hey @unvalley sorry for the rebase I've handed you. If you need help with the rebase let me know.

[unvalley]

@ehiggs No worries, Thanks for fixing clippy errors!

[unvalley]

@curquiza Ok, I fixed conflicts. Could you run the CI again?

[curquiza]

bors try

[unvalley]

oops, it conflicts again.

[bors[bot]]

try

Merge conflict.

[unvalley]

@curquiza I fixed conflicts again 🙏🏻

[unvalley]

okay, the errors relate to facets refactoring. I'll fix that.

[curquiza]

bors try

[bors[bot]]

try

Build failed:

• Run Clippy

[unvalley]

@curquiza I fixed conflicts again😆 (sorry for trying bors many times!)

[curquiza]

bors try

[bors[bot]]

try

Build failed:

• Run Rustfmt

[unvalley]

fixed rust fmt🔥

[curquiza]

Bors try

[bors[bot]]

try

Build failed:

• Run Clippy

[unvalley]

@curquiza I finally removed the clippy job in this pr to receive a code review for the current code change. I'll add the job in this pr.

[curquiza]

Ok @unvalley! Can you remove the issue from the Development section (on the right) then?

[irevoire]

Hey @unvalley, since this is quite a big PR and you had to rebase a lot of changes we wanted to thank you for your time and accept your contribution for the hacktoberfest even though we're probably not going to merge it before the end of the event. That's why I gave you the hacktoberfest-accepted tag. And if you would like to receive some swag from Meilisearch, please complete this form.

[unvalley]

@irevoire Thanks for letting me know! I completed the form. I'd like to contribute more.

[curquiza]

And thanks for being such reactive @unvalley! You are more than welcome to contributing again 😄

[curquiza]

@Kerollmops could you take a look at it? And if you approve the PR, please merge it 🚀

[bors[bot]]

Build succeeded:

• Run Rustfmt
• Tests on macos-latest
• Tests on ubuntu-20.04
• Tests on windows-latest

[meili-bot]

This message is sent automatically

Thank you for contributing to Meilisearch. If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.