meilisearch / milli

Search engine library for Meilisearch ⚡️

MIT License

464 stars 81 forks source link

Add clippy job #673

Closed unvalley closed 2 years ago

unvalley commented 2 years ago

Pull Request

Related issue

Fixes #231

What does this PR do?

fix some clippy errors remain
add clippy job to CI (I set nightly as toolchain)

PR checklist

Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

meili-bot commented 2 years ago

This message is sent automatically

Hello @unvalley, Thank you very much for contributing to Meilisearch :heart:. However, the team is not available on the weekend, but they will be back on Monday :blush:

curquiza commented 2 years ago

I put hacktoberfest-accepted to this one too, since it will be definitely helpful for this project once #659 is merged

Thanks @unvalley for the work

unvalley commented 2 years ago

@curquiza This pr is review ready. (Clippy is now success on CI)

ehiggs commented 2 years ago

Nice work @unvalley!

bors[bot] commented 2 years ago

Build succeeded: