`ubuntu-latest` is a better label for `20.04`

meilisearch / milli

Search engine library for Meilisearch ⚡️

MIT License

464 stars 82 forks source link

`ubuntu-latest` is a better label for `20.04` #684

Closed azzamsa closed 1 year ago

azzamsa commented 1 year ago

Hi.

If we use <OS>-latest for all the runner labels. Wouldn't it be better to use -latest too for ubuntu-20.04?

https://github.com/actions/runner-images#available-images

One of the best advantages is that we don't need to change the runner version each time a new version is released or deprecated.

Related PR:

https://github.com/meilisearch/milli/pull/683

curquiza commented 1 year ago

Hello @azzamsa We would rather not use the latest versions of ubuntu since it can lead to CI breaking from one day to another without controlling it. We prefer working with fixed and specified versions.

Thanks for the suggestion but I'm sorry I have to close this issue since this is not something we want to do 😊